fix: alot

apps/api/src/devices/devices.service.spec.ts

@@ -1,12 +1,12 @@
 import { Prisma } from '@prisma/client';
 import { DevicesService } from './devices.service';
 
-type Snapshot = { tabId: string; customerName: string; version: number; totalInCents: number; itemCount: number };
+type Snapshot = { tabId: string; customerName: string; version: number; totalInCents: number; itemCount: number; items?: unknown };
 
 function createService({ previous = [] as Snapshot[], delivered = 0, expired = 0 } = {}) {
   const tx = {
-    tabOwnership: { deleteMany: jest.fn(), upsert: jest.fn() },
-    openTabSnapshot: { deleteMany: jest.fn(), upsert: jest.fn() },
+    tabOwnership: { deleteMany: jest.fn(), upsert: jest.fn(), updateMany: jest.fn() },
+    openTabSnapshot: { deleteMany: jest.fn(), upsert: jest.fn(), updateMany: jest.fn() },
     plannedTab: { updateMany: jest.fn().mockResolvedValue({ count: delivered }) },
     device: { update: jest.fn() },
   };
@@ -27,13 +27,13 @@ const device = { id: 'd1', venueId: 'v1', revokedAt: null, lastSeenAt: new Date(
 const tab = (id: string, customerName: string) => ({ id, customerName, version: 1, totalInCents: 0, itemCount: 0 });
 
 describe('DevicesService.sync planned customers', () => {
-  it('marks planned customers delivered once the device reports a tab with their name', async () => {
+  it('marks planned customers delivered once the device reports a tab with their name, ignoring case', async () => {
     const { service, tx } = createService();
 
-    await service.sync(device, { deviceId: 'd1', openTabs: [tab('t1', 'Jan'), tab('t2', 'Piet')] });
+    await service.sync(device, { deviceId: 'd1', openTabs: [tab('t1', 'Jan'), tab('t2', ' piet  Peeters')] });
 
     expect(tx.plannedTab.updateMany).toHaveBeenCalledWith({
-      where: { venueId: 'v1', deliveredAt: null, customerName: { in: ['Jan', 'Piet'] } },
+      where: { venueId: 'v1', deliveredAt: null, customerNameKey: { in: ['jan', 'piet peeters'] } },
       data: { deliveredAt: expect.any(Date) },
     });
   });
@@ -125,3 +125,32 @@ describe('DevicesService.sync tab lines', () => {
     expect(tx.openTabSnapshot.upsert.mock.calls[0][0].update.items).toBe(Prisma.JsonNull);
   });
 });
+
+describe('DevicesService.sync writes', () => {
+  const items = [{ productName: 'Cola', quantity: 10, unitPriceInCents: 250 }];
+  const jan = { id: 't1', customerName: 'Jan', version: 2, totalInCents: 2500, itemCount: 10, items };
+  // JSONB doesn't keep key order
+  const janSnapshot = { tabId: 't1', customerName: 'Jan', version: 2, totalInCents: 2500, itemCount: 10, items: [{ quantity: 10, productName: 'Cola', unitPriceInCents: 250 }] };
+
+  it('only bumps the report time of unchanged tabs', async () => {
+    const { service, tx } = createService({ previous: [janSnapshot] });
+
+    await service.sync(device, { deviceId: 'd1', openTabs: [jan] });
+
+    expect(tx.openTabSnapshot.upsert).not.toHaveBeenCalled();
+    expect(tx.tabOwnership.upsert).not.toHaveBeenCalled();
+    expect(tx.openTabSnapshot.updateMany).toHaveBeenCalledWith({
+      where: { deviceId: 'd1', tabId: { in: ['t1'] } },
+      data: { reportedAt: expect.any(Date) },
+    });
+  });
+
+  it('writes a tab whose lines changed', async () => {
+    const { service, tx } = createService({ previous: [janSnapshot] });
+
+    await service.sync(device, { deviceId: 'd1', openTabs: [{ ...jan, items: [{ ...items[0], quantity: 11 }] }] });
+
+    expect(tx.openTabSnapshot.upsert).toHaveBeenCalledTimes(1);
+    expect(tx.openTabSnapshot.updateMany).not.toHaveBeenCalled();
+  });
+});